OCDAV: map bad request and unimplemented codes #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
force-pushed
the
ocdav-handle-bad-request
branch
from
01ec606 to
e48e169
Compare
|
@butonic can we make this a bit modular? So many switch cases make reading through the code a bit difficult. |
butonic
force-pushed
the
ocdav-handle-bad-request
branch
from
e48e169 to
f5f0b42
Compare
|
@ishank011 I moved the switch to a function and now use that throughout the ocdav handler. Using subloggers this even allows logging additional fields, eg. I deleted more lines than I added, so I'm happy. |
ishank011
previously approved these changes
Dec 2, 2020
butonic
force-pushed
the
ocdav-handle-bad-request
branch
from
f5f0b42 to
74f541f
Compare
|
@butonic maybe rebase |
butonic
force-pushed
the
ocdav-handle-bad-request
branch
from
74f541f to
f374ded
Compare
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
ocdav-handle-bad-request
branch
from
f374ded to
b8a6a42
Compare
|
@labkode I had swallowed a conflic status when refactoring ... good to merge now. |
labkode
approved these changes
Dec 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now return a 400 bad request when a grpc call fails with an invalid argument status and a 501 not implemented when it fails with an unimplemented status. This prevents 500 errors when a user tries to add resources to the Share folder or a storage does not implement an action.
This is part of a series to get 500 errors returned as proper 400 errors: owncloud/product#7